Update DAB CLI to return appropriate exit codes based upon exit reason#2084
Merged
seantleonard merged 13 commits intomainfrom Mar 29, 2024
Merged
Update DAB CLI to return appropriate exit codes based upon exit reason#2084seantleonard merged 13 commits intomainfrom
seantleonard merged 13 commits intomainfrom
Conversation
…revision can explore returning specific codes for each unique error.
1 task
seantleonard
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
neeraj-sharma2592,
ravishetye,
rohkhann,
severussundar,
sourabh1007 and
tarazou9
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Aniruddh25
requested changes
Mar 11, 2024
1 task
abhishekkumams
approved these changes
Mar 22, 2024
aaronburtle
reviewed
Mar 28, 2024
aaronburtle
reviewed
Mar 28, 2024
aaronburtle
approved these changes
Mar 28, 2024
Contributor
aaronburtle
left a comment
aaronburtle
left a comment
There was a problem hiding this comment.
Looks good, just a nit.
…ults in error tracking. also added "actual" named param to assert test cases for consistency since "expected" was included.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
dab start {options}may contain fully valid values, but when used as arguments to start the DAB engine process within CLI, engine startup fails. The failure didn't get reflected as error code -1.dab init {options}may reference a file that already exists in the path that the CLI uses to read/write config files, this results in an error that is not properly reflected in the exit code.What is this change?
0success-1failureisSuccesswithin theoptions.Handler()methods, the handler methods all return the int error code now.How was this tested?