Upgrade HotChocolate#1854
Merged
Aniruddh25 merged 8 commits intomainfrom Nov 7, 2023
Merged
Conversation
Aniruddh25
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
seantleonard
previously requested changes
Nov 2, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
are the failing tests a result of this change or transient that would resolve on pipeline retry?
Collaborator
Author
some of them were due to this change since hotchocolate changed the response codes, I tested with previous version - 0.8.49... |
seantleonard
approved these changes
Nov 7, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
thanks for keeping dependencies up to date!
abhishekkumams
approved these changes
Nov 7, 2023
Aniruddh25
added a commit
that referenced
this pull request
Nov 13, 2023
## Why make this change? - Pick up latest patch version for HotChocolate 12 for bug fixes. ## What is this change? - Upgrade the patch version number in the global properties for all HotChocolate.* packages ## How was this tested? - Verified BCP is launched for local dev and can query GraphQL. - Existing integration tests -fix some to accommodate how upgraded hotchocolate behaves
Aniruddh25
added a commit
that referenced
this pull request
Nov 13, 2023
## Why make this change? This is simply cherry-picking the following PRs before creating the next stable 0.9 version: - #1876 - #1821 - #1854 - #1851 - #1872 - #1868 --------- Co-authored-by: Sean Leonard <[email protected]> Co-authored-by: Abhishek Kumar <[email protected]> Co-authored-by: neeraj-sharma2592 <[email protected]> Co-authored-by: Neeraj Sharma (from Dev Box) <[email protected]> Co-authored-by: aaronburtle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?