Skip to content

[CherryPick] Update dab.draft.schema.json (#1782)#1837

Merged
seantleonard merged 1 commit intorelease/0.9from
dev/seantleonad/updateschemajson
Oct 23, 2023
Merged

[CherryPick] Update dab.draft.schema.json (#1782)#1837
seantleonard merged 1 commit intorelease/0.9from
dev/seantleonad/updateschemajson

Conversation

@seantleonard
Copy link
Copy Markdown
Contributor

Cherry pick #1782 to 0.9 branch.

Why make this change?

  • Currently our config and schema file had some differences, which is why even the config we support was showing to contain errors.

What is this change?

  • updating schema to reflect the correct supported config file.

How was this tested?

Screenshots

Before

image

After

image


Why make this change?

  • Reference associated issue using # syntax. e.g. Closes #XX
    • Include summary (1-2 sentences) of linked issue to avoid redirecting reviewers to different pages.
    • Include links to any additional discussion threads related to this change.

What is this change?

  • Summary of how your changes work to give reviewers context of your intent.
    • Links to relevant documentation / StackOverflow, if applicable.

How was this tested?

  • Integration Tests
  • Unit Tests

Sample Request(s)

  • Example REST and/or GraphQL request to demonstrate modifications
  • Example of CLI usage to demonstrate modifications

## Why make this change?

- Currently our config and schema file had some differences, which is
why even the config we support was showing to contain errors.

## What is this change?
- updating schema to reflect the correct supported config file.

## How was this tested?

- Online Tool: https://www.jsonschemavalidator.net/

## Screenshots

### Before

![image](https://github.com/Azure/data-api-builder/assets/102276754/77664442-ba43-4e75-ad79-728a51686b10)


### After

![image](https://github.com/Azure/data-api-builder/assets/102276754/ff1c2873-fddc-4340-ac06-7aa90ac636cc)

---------

Co-authored-by: Aniruddh Munde <[email protected]>
@seantleonard seantleonard merged commit 297096d into release/0.9 Oct 23, 2023
@seantleonard seantleonard deleted the dev/seantleonad/updateschemajson branch October 23, 2023 15:38
@seantleonard seantleonard added the 🍒Cherrypick Cherry-picking another commit/PR label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒Cherrypick Cherry-picking another commit/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants