Update dab.draft.schema.json#1782
Conversation
abhishekkumams
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
|
on the topic of fixing json schema validation, should this PR address #1793? Can our |
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
as a pre-req to merging this, please open a PR updating the public documentation's description of GraphQL and REST settings for an entity. There is no reference to "enabled" property and there is also still reference to allowing the config:
rest: "true",
graphql: "true"this section also seems to be inaccurate:
https://learn.microsoft.com/en-us/azure/data-api-builder/configuration-file#graphql-operation
{
"graphql": "true",
"operation": "query"
}updating $schema url
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Created a PR for the above in docs |
## Why make this change? - Currently our config and schema file had some differences, which is why even the config we support was showing to contain errors. ## What is this change? - updating schema to reflect the correct supported config file. ## How was this tested? - Online Tool: https://www.jsonschemavalidator.net/ ## Screenshots ### Before  ### After  --------- Co-authored-by: Aniruddh Munde <[email protected]>
Cherry pick #1782 to 0.9 branch. ## Why make this change? - Currently our config and schema file had some differences, which is why even the config we support was showing to contain errors. ## What is this change? - updating schema to reflect the correct supported config file. ## How was this tested? - Online Tool: https://www.jsonschemavalidator.net/ ## Screenshots ### Before  ### After  --------- ## Why make this change? - Reference associated issue using `#` syntax. e.g. Closes #XX - Include summary (1-2 sentences) of linked issue to avoid redirecting reviewers to different pages. - Include links to any additional discussion threads related to this change. ## What is this change? - Summary of how your changes work to give reviewers context of your intent. - Links to relevant documentation / StackOverflow, if applicable. ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) - Example REST and/or GraphQL request to demonstrate modifications - Example of CLI usage to demonstrate modifications Co-authored-by: Abhishek Kumar <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]>
4 participants
Why make this change?
What is this change?
How was this tested?
Screenshots
Before
After