Fix setting cosmos configuration at runtime by checking whether the graphql schema is set#1739
Merged
Aniruddh25 merged 4 commits intorelease/0.8from Sep 21, 2023
Merged
Conversation
Mathos1432
requested review from
Aniruddh25,
JelteF,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
reviewed
Sep 21, 2023
seantleonard
approved these changes
Sep 21, 2023
Aniruddh25
approved these changes
Sep 21, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix and the accompanying test!
seantleonard
pushed a commit
that referenced
this pull request
Sep 22, 2023
…raphql schema is set (#1739) ## Why make this change? Failing to set the configuration at runtime if there is not "schema" file set in the config. This is not required when setting the config at runtime since the graphql schema is set already. ## How was this tested? - [x] Validated locally - [x] Updated the tests so the schema property is removed from the config. Verified that the tests were failing before the fix and passing after.
seantleonard
pushed a commit
that referenced
this pull request
Sep 22, 2023
…raphql schema is set (#1739) ## Why make this change? Failing to set the configuration at runtime if there is not "schema" file set in the config. This is not required when setting the config at runtime since the graphql schema is set already. ## How was this tested? - [x] Validated locally - [x] Updated the tests so the schema property is removed from the config. Verified that the tests were failing before the fix and passing after.
2 tasks
abhishekkumams
pushed a commit
that referenced
this pull request
Sep 25, 2023
…whether the graphql schema is set (#1743) ## Context Cherry-picking #1739 from `release/0.8` to main and also resolved merge conflicts. Remainder of description copied from #1739 PR description. ## Why make this change? Failing to set the configuration at runtime if there is not "schema" file set in the config. This is not required when setting the config at runtime since the graphql schema is set already. ## How was this tested? - [x] Validated locally - [x] Updated the tests so the schema property is removed from the config. Verified that the tests were failing before the fix and passing after. Co-authored-by: Mathieu Tremblay <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]>
seantleonard
added a commit
that referenced
this pull request
Sep 25, 2023
…whether the graphql schema is set (#1743) ## Context Cherry-picking #1739 from `release/0.8` to main and also resolved merge conflicts. Remainder of description copied from #1739 PR description. ## Why make this change? Failing to set the configuration at runtime if there is not "schema" file set in the config. This is not required when setting the config at runtime since the graphql schema is set already. ## How was this tested? - [x] Validated locally - [x] Updated the tests so the schema property is removed from the config. Verified that the tests were failing before the fix and passing after. Co-authored-by: Mathieu Tremblay <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]>
2 tasks
Aniruddh25
added a commit
that referenced
this pull request
Sep 26, 2023
…whether the graphql schema is set (#1746) ## Context Cherry-picking #1739 from `main` to `release/0.9` which includes the merge conflicts resolved for merging into main. Remainder of description copied from #1739 PR description. ## Why make this change? Failing to set the configuration at runtime if there is not "schema" file set in the config. This is not required when setting the config at runtime since the graphql schema is set already. ## How was this tested? - [x] Validated locally - [x] Updated the tests so the schema property is removed from the config. Verified that the tests were failing before the fix and passing after. Co-authored-by: Mathieu Tremblay <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Failing to set the configuration at runtime if there is not "schema" file set in the config. This is not required when setting the config at runtime since the graphql schema is set already.
How was this tested?