Adding support for positive boolean options in CLI#1686
Merged
Conversation
ayush3797
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
2 tasks
seantleonard
approved these changes
Sep 14, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Looks good! one last question
abhishekkumams
approved these changes
Sep 15, 2023
ayush3797
deleted the
dev/agarwalayush/supportForPositiveBooleanFlags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
To adjust CLI boolean options to properly allow true/false values as per: #1679
What is this change?
--rest.enabledand--graphql.enabledtodab initoptions.CliBoolwith values -None,True,False, to represent boolean options in CLI. When the option is omitted from the init command, the value ofCliBool.Nonewould be assigned to the option, or else appropriateTrue/Falsevalue would be parsed out and assigned to the option.Runtime.Rest.Enabled/Runtime.GraphQL.Enabledproperties.--rest.enabled/--rest.disabled(or corresponding flags for graphql) option is included in the init command, the value assigned to that option is honored.How was this tested?
EndToEndTests.TestEnabledDisabledFlagsForApistest confirming the behavior for different cases.