Remove redundant logging of found config file#1669
Merged
Aniruddh25 merged 8 commits intomainfrom Aug 30, 2023
Merged
Conversation
Aniruddh25
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
ayush3797
approved these changes
Aug 30, 2023
Contributor
|
does this PR also address the issue here ? |
Collaborator
Author
yes it does |
1 task
abhishekkumams
approved these changes
Aug 30, 2023
Aniruddh25
added a commit
that referenced
this pull request
Aug 30, 2023
- With the overhaul of config system PR #1402 , we started seeing redundant logs about which config file is being used. - Store the environment based config file name found at construction time in the property `ConfigFileName`. - Remove Console writeline statements while checking for existence of file since this leads to multiple logs - one from CLI before starting the engine and second from within the engine itself when calling TryPargeConfig - Add a single log of the loaded file in CLI - Also catch exception for incorrect connection string parsing - Manually, using the `start` command of CLI as well as triggering the engine directly with argument: `--ConfigFileName` 1. Starting with default config: **Before**:  **After**:  2. Starting with user provided config: **Before**:  **After**:  3. Trying to start with missing file name - same behvior as before 
Aniruddh25
added a commit
that referenced
this pull request
Aug 30, 2023
Cherry picking #1669 Original description: ## Why make this change? - With the overhaul of config system PR #1402 , we started seeing redundant logs about which config file is being used. ## What is this change? - Store the environment based config file name found at construction time in the property `ConfigFileName`. - Remove Console writeline statements while checking for existence of file since this leads to multiple logs - one from CLI before starting the engine and second from within the engine itself when calling TryPargeConfig - Add a single log of the loaded file in CLI ## How was this tested? - Manually, using the `start` command of CLI as well as triggering the engine directly with argument: `--ConfigFileName` 1. Starting with default config: **Before**:  **After**:  2. Starting with user provided config: **Before**:  **After**:  3. Trying to start with missing file name - same behvior as before 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
ConfigFileName.How was this tested?
startcommand of CLI as well as triggering the engine directly with argument:--ConfigFileNameBefore:
After:
Before:
After:
