Structured Logging (Service Project)#1666
Merged
seantleonard merged 3 commits intomainfrom Sep 6, 2023
Merged
Conversation
…es by using exception parameter in iLogger which captures and outputs exception stacktrace and message by design.
seantleonard
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
severussundar and
tarazou9
as code owners
aaronpowell
approved these changes
Aug 29, 2023
Contributor
|
There are some places in COnfigurationController.cs class where we Log some error without correlationId, Is there a seperate issue for updating it? |
Contributor
Author
Updated in this pr since configurationcontroller.cs is in the service project. Thanks for bringing my attention to that. |
Aniruddh25
approved these changes
Sep 6, 2023
seantleonard
deleted the
dev/seantleonard/structuredLogging_Service_config
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
messageparameter, names in curly brackets are names that can be filtered in a log view such as app insights/log analytics. The parameters after message are the variables which supply the values for the names in curly brackets.testing
Testing is manual via analyzing the console, no logic changes were made to the engine.