Remove duplicate exception logged to console during startup failure.#1664
Merged
seantleonard merged 4 commits intomainfrom Sep 18, 2023
Merged
Conversation
…uring startup failure to make it easier to parse console messaging.
seantleonard
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
severussundar and
tarazou9
as code owners
aaronpowell
approved these changes
Aug 29, 2023
Contributor
|
Can you check if it works for cases where exception is thrown outside Program.cs,
To reproduce:
|
Aniruddh25
approved these changes
Sep 9, 2023
seantleonard
deleted the
dev/seantleonard/structuredLogging_ServiceConfig
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
-Work done as part of structured logging overhaul. #1517
What is this change?
-Adds named parameters in ilogger call while making message generation for the console more concise. ILogger logError() and other ilogger calls allow you to include a parameter for the exception. That is logged automatically in ilogger so we don't have to additionally log the exception message in the logger message manually.
How was this tested?
manual testing:
before:
after:
Sample Request(s)
"path": " /pathName"