Skip to content

Move to file scoped namespaces#1661

Closed
gmottajr wants to merge 23 commits intoAzure:mainfrom
gmottajr:MoveToFileScopedNamespaces
Closed

Move to file scoped namespaces#1661
gmottajr wants to merge 23 commits intoAzure:mainfrom
gmottajr:MoveToFileScopedNamespaces

Conversation

@gmottajr
Copy link
Copy Markdown
Contributor

This is an issue posted in GitHUb #1595

It has been requested a refactoring moving to file scoped namespace.

gerson added 22 commits August 27, 2023 13:07
@seantleonard
Copy link
Copy Markdown
Contributor

Hi @gmottajr thank you for contributing this change!

It would be really helpful for reviewers to divide this change into multiple PRs scoped to a per project basis. That way, the lower file count will reduce feedback turnaround time and thus get your changes merged quicker.

Looks like you already have your commits broken down into consumable chunks so that would be a good place to start.

@gmottajr
Copy link
Copy Markdown
Contributor Author

gmottajr commented Aug 29, 2023 via email

@gmottajr
Copy link
Copy Markdown
Contributor Author

gmottajr commented Aug 29, 2023 via email

@seantleonard
Copy link
Copy Markdown
Contributor

Hi @gmottajr,

Can you divide this change into multiple PRs -- scoped to a per project basis? (e.g. Core, Service, CLI, Service.Tests, Config). That will enable reviewers to provide quicker reviews incrementally.

There are currently 239 files changes, where GitHub unfortunately shows many changes when, in reality, just the file scoped namespaces were added.

@seantleonard seantleonard added this to the 0.10rc milestone Sep 6, 2023
@gmottajr
Copy link
Copy Markdown
Contributor Author

gmottajr commented Sep 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants