Adds SourceLink dependency to Product module#1657
Merged
Aniruddh25 merged 3 commits intomainfrom Aug 25, 2023
Merged
Conversation
severussundar
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard and
tarazou9
as code owners
1 task
seantleonard
approved these changes
Aug 25, 2023
abhishekkumams
approved these changes
Aug 25, 2023
Aniruddh25
deleted the
dev/shyamsundarj/add-sourcelink-deps-product-module
branch
Aniruddh25
added a commit
that referenced
this pull request
Aug 26, 2023
…#1656) ## Why make this change? - Closes #1655 - Health of [0.8.44-rc nupkg](https://nuget.info/packages/Microsoft.DataApiBuilder/0.8.44-rc) nupkg needs to be fixed ## What is this change? - To fix the NuGet generated in the `main` branch, `Product` and `Core` modules needs to be updated. `Product` module was introduced later and `0.8.*` NuGets do not have the Product module. So, the fix is broken into two PRs. - This PR adds changes only to the `Core` module. After merging to `main`, this PR can be ported over to `release/0.8` branch. - [PR #1657 ](#1657) adds the changes to `Product` module. - Sets `EmbedUntrackedSources` and `ContinuousIntegrationBuild` to `true` ## How was this tested? - [x] Manual Tests By applying the change on top of the `release/0.8` branch, the health of the NuGet generated was validated  --------- Co-authored-by: Aniruddh Munde <[email protected]>
Aniruddh25
added a commit
that referenced
this pull request
Aug 26, 2023
…#1656) ## Why make this change? - Closes #1655 - Health of [0.8.44-rc nupkg](https://nuget.info/packages/Microsoft.DataApiBuilder/0.8.44-rc) nupkg needs to be fixed ## What is this change? - To fix the NuGet generated in the `main` branch, `Product` and `Core` modules needs to be updated. `Product` module was introduced later and `0.8.*` NuGets do not have the Product module. So, the fix is broken into two PRs. - This PR adds changes only to the `Core` module. After merging to `main`, this PR can be ported over to `release/0.8` branch. - [PR #1657 ](#1657) adds the changes to `Product` module. - Sets `EmbedUntrackedSources` and `ContinuousIntegrationBuild` to `true` ## How was this tested? - [x] Manual Tests By applying the change on top of the `release/0.8` branch, the health of the NuGet generated was validated  --------- Co-authored-by: Aniruddh Munde <[email protected]>
1 task
Aniruddh25
added a commit
that referenced
this pull request
Aug 26, 2023
…for Core module… (#1660) Cherry-Picks (#1656) to release/0.8 branch **Original Description:** ## Why make this change? - Closes #1655 - Health of [0.8.44-rc nupkg](https://nuget.info/packages/Microsoft.DataApiBuilder/0.8.44-rc) nupkg needs to be fixed ## What is this change? - To fix the NuGet generated in the `main` branch, `Product` and `Core` modules needs to be updated. `Product` module was introduced later and `0.8.*` NuGets do not have the Product module. So, the fix is broken into two PRs. - This PR adds changes only to the `Core` module. After merging to `main`, this PR can be ported over to `release/0.8` branch. - [PR #1657 ](#1657) adds the changes to `Product` module. - Sets `EmbedUntrackedSources` and `ContinuousIntegrationBuild` to `true` ## How was this tested? - [x] Manual Tests By applying the change on top of the `release/0.8` branch, the health of the NuGet generated was validated  --------- Co-authored-by: Shyam Sundar J <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
SourceLinkNuGet health property is notvaliddue to the absence of SourceLink dependencyWhat is this change?
SourceLinkdependency is added to theProductmoduleSourceLinkembeds the git commit ID to assembly metadata. So, the application name will be of the formdab_oss_1.0.0+<commit_id>. So, test assertion logic is updated.How was this tested?