Addressing left over review comments from #1641#1650
Merged
Aniruddh25 merged 2 commits intomainfrom Aug 24, 2023
Merged
Conversation
Aniruddh25
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
commented
Aug 24, 2023
seantleonard
approved these changes
Aug 24, 2023
aaronburtle
approved these changes
Aug 24, 2023
Aniruddh25
added a commit
that referenced
this pull request
Aug 24, 2023
## Why make this change? - Accidentally completed the PR #1641 before pushing the last commit that addressed review comments. I had it on my local branch, but forgot to push before merging in. This PR is to push those left over review comments into main.
Aniruddh25
added a commit
that referenced
this pull request
Aug 24, 2023
## Why make this change? - Cherry-picks #1641 and #1650 to 0.8 release --------- Co-authored-by: Sean Leonard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
start#1641 before pushing the last commit that addressed review comments. I had it on my local branch, but forgot to push before merging in. This PR is to push those left over review comments into main.