Skip to content

Enable Application Insights For Non Hosted Scenario#1649

Merged
abhishekkumams merged 83 commits intomainfrom
dev/abhishekkuma/enable_application_insights
Sep 21, 2023
Merged

Enable Application Insights For Non Hosted Scenario#1649
abhishekkumams merged 83 commits intomainfrom
dev/abhishekkuma/enable_application_insights

Conversation

@abhishekkumams
Copy link
Copy Markdown
Contributor

@abhishekkumams abhishekkumams commented Aug 24, 2023

Why make this change?

  • Closes RFC: Enable Application Insights #1601
    • This PR aims to Integrate Application Insights to Data API builder, which will allow developers to monitor and gain insights into the performance and usage of their applications.

What is this change?

  • Added a new optional property called Telemetry to runtime config that will contain information about ApplicationInsights connection string. users can enable/disable it as well.
  • If Application Insights is enabled, All the Application Logs that is currently generated by Data API builder will now be sent to Application Insights.

How was this tested?

  • Manual Tests: Logs are being populated in the Application Insights portal
  • Unit Tests

Images from Azure Portal

  1. Live Metrics

image

  1. Logs

image

  1. Requests

image

  1. Exceptions

image

@abhishekkumams abhishekkumams changed the title Enable Application Insights Enable Application Insights For Non Hosted Scenario Sep 20, 2023
Comment thread src/Product/ProductInfo.cs Outdated
Comment thread src/Service/Startup.cs Outdated
Comment thread src/Service/Telemetry/ApplicationInsightsLoggerProvider.cs Outdated
Comment thread src/Service.Tests/Configuration/TelemetryTests.cs
Comment thread src/Service.Tests/Configuration/TelemetryTests.cs
Copy link
Copy Markdown
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for enabling AppInsights!

Copy link
Copy Markdown
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for making changes and building this feature!

@abhishekkumams abhishekkumams merged commit 7c4bac2 into main Sep 21, 2023
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/enable_application_insights branch September 21, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

RFC: Enable Application Insights

4 participants