Fix for guid filter in GraphQL#1644
Merged
Aniruddh25 merged 16 commits intomainfrom Aug 25, 2023
Merged
Conversation
1 task
ayush3797
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
requested changes
Aug 22, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! Few suggestions
Aniruddh25
reviewed
Aug 23, 2023
ayush3797
commented
Aug 24, 2023
seantleonard
requested changes
Aug 24, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
I'm confused why we're mapping mssql GUID to GraphQL Type ID.
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
just last two questions.
Aniruddh25
reviewed
Aug 25, 2023
Aniruddh25
reviewed
Aug 25, 2023
Aniruddh25
reviewed
Aug 25, 2023
Aniruddh25
reviewed
Aug 25, 2023
seantleonard
approved these changes
Aug 25, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
thanks for addressing concerns!
Aniruddh25
added a commit
that referenced
this pull request
Aug 25, 2023
## Why make this change? Fix #1598 to ensure GQL filter works with guid types. ## What is this change? Correctly resolved guid type to Hotchocolate type of `UUID` (per: https://chillicream.com/docs/hotchocolate/v12/defining-a-schema/scalars#uuid-type) which was earlier resolved to string. Accordingly parsed the guid values using `Guid.Parse()` method instead of parsing it as string. ## How was this tested? - [x] Unit Tests - `SchemaConverterTests` - [X] Integration Tests - Added filter tests with GUID to `GraphQLSupportedTypesTestsBase.QueryTypeColumnFilterAndOrderBy` --------- Co-authored-by: Aniruddh Munde <[email protected]>
Aniruddh25
added a commit
that referenced
this pull request
Aug 26, 2023
- Cherry picks PR #1644 to 0.8 release as a bug fix patch. --------- Co-authored-by: Ayush Agarwal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Fix #1598 to ensure GQL filter works with guid types.
What is this change?
Correctly resolved guid type to Hotchocolate type of
UUID(per: https://chillicream.com/docs/hotchocolate/v12/defining-a-schema/scalars#uuid-type) which was earlier resolved to string. Accordingly parsed the guid values usingGuid.Parse()method instead of parsing it as string.How was this tested?
SchemaConverterTestsGraphQLSupportedTypesTestsBase.QueryTypeColumnFilterAndOrderBy