Runtime config changes for multiple database support by rohkhann · Pull Request #1639 · Azure/data-api-builder

rohkhann · 2023-08-18T01:50:56Z

Why make this change?

In this pr, RuntimeConfig object is extended to support multiple database scenario. Along with this all the class objects are respectively extended to be able to take multiple database input.
Consequently, there are downstream changes done in the different executors. Currently each executor will use the default datasource to run their queries.
In subsequent pr's through Named dependency injection, the executors will be able to choose which db to act against.
Please see RFC: RFC: Multiple data sources #1638

What is this change?

This change is meant to be part of a series of changes that will enable multiple database support on data api builder.
This first change ensures compatibility of runtimeconfig with multiple database approach.
This change does not unlock any new scenario as of now. (there will be further pr's that will build on this change to fully support multiple database scenario). It just extends runtimeconfig while ensuring that the single datasource scenario works as expected.

How was this tested?

Existing integration tests cover all execution paths to test for backword compatibility.
Ran dab locally as well to test that it works.
Existing unit tests cover all execution paths to test for backword compatibility.

…e default names from the runtime config.

…ttps://github.com/Azure/data-api-builder into rohkhann/RuntimeConfigSupportForMultipleDatasources

seantleonard

Thank you for driving and implementing this new capability!

…sources

Aniruddh25

Testfiles code review remaining.

…ttps://github.com/Azure/data-api-builder into rohkhann/RuntimeConfigSupportForMultipleDatasources

…sources

…ttps://github.com/Azure/data-api-builder into rohkhann/RuntimeConfigSupportForMultipleDatasources

…sources

…ttps://github.com/Azure/data-api-builder into rohkhann/RuntimeConfigSupportForMultipleDatasources

Aniruddh25

Thanks for working on this, and your patience while it took time for us to review! LGTM after last bit of comments are resolved.

…sources

rohkhann added 7 commits August 17, 2023 18:30

First commit - runtime config changes for multiple database support

9072184

dotnet format

0151d3e

Merge with main.

920413e

merge with main

2a9a0b9

Ignore properties in moduleInitializer

6f0d000

Test fixes, cosmos clean up, remove unneccasry files.

07f6c8a

Support to set specific db cosmoshandler.Fixing query executors to us…

885f161

…e default names from the runtime config.

rohkhann changed the title ~~First commit - runtime config changes for multiple database support~~ Runtime config changes for multiple database support Aug 18, 2023

rohkhann added 3 commits August 18, 2023 11:44

Bug fix in initialize for non-cosmos db's

c6ae4a6

IsNullorEmpty fix.

a6779ee

connection string fix.

c4b9bc1

rohkhann marked this pull request as ready for review August 18, 2023 19:40

rohkhann requested review from Aniruddh25, JelteF, Mathos1432, aaronburtle, aaronpowell, abhishekkumams, ayush3797, gledis69, mbhaskar, milismsft, ravishetye, seantleonard, severussundar and tarazou9 as code owners August 18, 2023 19:40

ayush3797 reviewed Aug 22, 2023

View reviewed changes

Comment thread src/Config/RuntimeConfigLoader.cs Outdated

ayush3797 reviewed Aug 22, 2023

View reviewed changes

Comment thread src/Config/RuntimeConfigLoader.cs Outdated

ayush3797 reviewed Aug 22, 2023

View reviewed changes

Comment thread src/Config/RuntimeConfigLoader.cs Outdated

ayush3797 reviewed Aug 22, 2023

View reviewed changes

Comment thread src/Config/RuntimeConfigLoader.cs Outdated

rohkhann requested a review from seantleonard August 25, 2023 00:39

Merge branch 'rohkhann/RuntimeConfigSupportForMultipleDatasources' of h…

30971cd

…ttps://github.com/Azure/data-api-builder into rohkhann/RuntimeConfigSupportForMultipleDatasources

seantleonard approved these changes Aug 25, 2023

View reviewed changes

Merge branch 'main' into rohkhann/RuntimeConfigSupportForMultipleData…

3a855c1

…sources