Adding application Name for mssql connections#1620
Merged
abhishekkumams merged 27 commits intomainfrom Aug 17, 2023
Merged
Conversation
abhishekkumams
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
previously requested changes
Aug 3, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Thanks for these changes, few questions..
Aniruddh25
reviewed
Aug 10, 2023
Aniruddh25
reviewed
Aug 10, 2023
Aniruddh25
reviewed
Aug 10, 2023
Aniruddh25
approved these changes
Aug 10, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
A check on Connstring builder, otherwise lgtm
Co-authored-by: Aniruddh Munde <[email protected]>
Co-authored-by: Aniruddh Munde <[email protected]>
seantleonard
requested changes
Aug 14, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
some nits and questions.
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
This was referenced Aug 16, 2023
seantleonard
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?
Sample Request(s)
Below are the Kusto Logs
