When databasename is empty it should not be added to prefix.#1605
Merged
When databasename is empty it should not be added to prefix.#1605
Conversation
rohkhann
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Contributor
|
Are we able to add tests for this? |
Aniruddh25
reviewed
Jul 24, 2023
Aniruddh25
approved these changes
Jul 28, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, left few nits.
Aniruddh25
reviewed
Jul 28, 2023
seantleonard
approved these changes
Jul 28, 2023
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
seantleonard
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
#syntax. e.g. Closes #XXFixes issue mentioned in : [Bug] When database name is empty it generates wrong sql query #1604
What is this change?
Added check to see if databasename is null or empty then we will not add it to the table prefix.
How was this tested?
existing integration tests test this path of code
Added new test called checkTablePrefix. Chose to go with internalsvisibleto route as the main goal was to test gettableprefix method and ROI on moqing out components of the public method initializeasync to do the test was low.