Merged
Conversation
rohkhann
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
aaronpowell
reviewed
Jul 17, 2023
aaronpowell
requested changes
Jul 17, 2023
Contributor
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
Added a few notes around naming conventions.
While I've provided them as suggestions on the GitHub code review, it'd be better to do the refactor in VS as then it'll update all references.
Also, the file names will need to be updated to match the new type names.
aaronpowell
reviewed
Jul 18, 2023
fixing typo. Co-authored-by: Aaron Powell <[email protected]>
…esystemruntimeconfigloader
…m/Azure/data-api-builder into rohkhann/RunTimeConfigConstructor
aaronpowell
approved these changes
Jul 18, 2023
Contributor
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
Generally speaking this looks good.
Added a small nit in there and some notes on where we've got areas that need to be reworked in the future phases of this workstream.
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
thanks for contributing these changes! just a couple comments
seantleonard
approved these changes
Jul 18, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Thanks for adding clarification to my questions
Aniruddh25
changed the title
Aniruddh25
changed the title
FileSystemRuntimeConfigLoader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Different users of dataapi builder may have different ways in which they want to load in runtimeconfig. For example: There is a scenario where one might want to create the runtimeconfig object dynamically without having a runtime json ready.
What is this change?
In this pr, we create an abstract base class RunTimeConfigLoader that has certain common methods that all derived classes can use. The main TryLoadconfig method will be implemented differently by different classes. The RunTimeConfigProvider by dab loads config from the filesystem. Depending on use case this can be done differently by different consumers.
How was this tested?
yes
yes