[BugFix] Handle configs which have missing options for MsSql#1580
Merged
Aniruddh25 merged 10 commits intomainfrom Jul 17, 2023
Merged
[BugFix] Handle configs which have missing options for MsSql#1580Aniruddh25 merged 10 commits intomainfrom
Aniruddh25 merged 10 commits intomainfrom
Conversation
Aniruddh25
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Thanks for adding. Pending addressing ci/cd build error
aaronpowell
reviewed
Jul 14, 2023
2 tasks
abhishekkumams
approved these changes
Jul 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
optionsproperty is not specified in the config, after deserialization theOptionsdictionary ofDataSourceobject isnullGetTypedOptions(MsSqlOptions)here.What is this change?
Optionsa nullable property since its not required as per the schema.How was this tested?
1. Removed the
options: set-session-contextfrom the initial config used in the CLI tests to verify deserialization results in a nullOptionsdictionary as demonstrated by the Snapshots2. Modified tests which create a custom config and start the engine by setting
Optionsto null and verifying those continue to pass.Note: The checked in configuration file for MsSql sets the session context to true for integration tests of row level security feature. So, did not modify that file even though options is optional for MsSql.