Nugetization refactor of DataApiBuilder#1539
Merged
Conversation
…or nugetization of dab that can be consumed by other projects.
rohkhann
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
mbhaskar
reviewed
Jun 27, 2023
Member
mbhaskar
left a comment
mbhaskar
left a comment
There was a problem hiding this comment.
Thank you for the changes. Could you also probably add basic design/block diagram of the proposed structure and how it is used? If you already have it in any other design doc, please link it here
Aniruddh25
changed the title
aaronpowell
reviewed
Jun 28, 2023
Contributor
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
Some tidy ups proposed.
Aniruddh25
reviewed
Jun 28, 2023
Aniruddh25
reviewed
Jun 28, 2023
Aniruddh25
approved these changes
Jun 28, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Overall looks good, left few rename suggestions.
Aniruddh25
reviewed
Jul 3, 2023
Aniruddh25
approved these changes
Jul 3, 2023
aaronpowell
approved these changes
Jul 3, 2023
Contributor
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
Really minor nit (can be ignored), otherwise good once tests pass.
Making class static Co-authored-by: Aaron Powell <[email protected]>
seantleonard
approved these changes
Jul 5, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Looks good, one nit about now-unneeded code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
This change is being made to allow nugetization of generic IP of Data api builder so that it can be consumed as a nuget by separate projects. There is no logic change or user experience change in this pr. It is a refactor of all the IP classes used by dab components into a separate c# library. Change has been internally discussed with DAB team as part of nugetization effort for DAB IP. This is an initial draft pr.
What is this change?
Created a new c# class library project that references auth and config projects. Moved all the folders from Service project to the new c# class project.
Pr is split into three commits for easier review:
Folders moved out of service to new project Azure.DataApiBuilder.Core:
New file created: Utils.cs in Core.
Service Old Folder Structure:
Service project New Folder Structure:
How was this tested?
Ran data api builder locally against mssql db
Ran unit tests listed on the contributions guidelines page
Sample Request(s)
No logic or workflow changes, just moving of files to a seperate project and reference changes
No logic or workflow changes, just moving of files to a seperate project and reference changes