Excluding null values from the generated config#1529
Merged
aaronpowell merged 233 commits intomainfrom Jul 6, 2023
Merged
Conversation
Finding missing types Refactoring some type names Simplifying the GraphQL naming by doing that when building the config, rather than on demand
Added implementation of JsonConverter.Write methods to generate an initial pass on the config file using CLI
Removed some tests that weren't testing the CLI but dependencies (such as CommandLineParser or ILogger)
…them simpler and clearer with the new object structure
Moved logic for Entities defaults to RuntimeEntities rather than deserialiser, as that is a more logical place. We always pass that type around, so we can assume the ctor ran, but we aren't always assuming the deserialiser ran (such as what happens with tests)
seantleonard
force-pushed
the
aaronpowell/new-config-engine-null-handling
branch
from
cf26b97 to
4b97d51
Compare
Aniruddh25
reviewed
Jun 30, 2023
seantleonard
reviewed
Jul 2, 2023
seantleonard
reviewed
Jul 2, 2023
seantleonard
approved these changes
Jul 2, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Two questions, but looks good!
Contributor
Author
|
This PR is reintroducing some stuff that it shouldn't, I'll have to check all the .NET changes again before it can be merged |
It was removed in 11eb639 as it would cause the config to never get loaded (see original commit for details)
Value should match the expected in Startup.cs (see https://github.com/Azure/data-api-builder/blob/2e8d1bb8b7d83bbe2a90472c2ccdc8acb87fa5ec/src/Service/Startup.cs#L61)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling a setting on the serializer that will exclude
nullwhen it's serializing the runtime config file.