Release0.7 with bug fix for CosmosDB field auth when graphql is true, include is *#1516
Merged
tarazou9 merged 6 commits intorelease/0.7from May 24, 2023
Merged
Release0.7 with bug fix for CosmosDB field auth when graphql is true, include is *#1516tarazou9 merged 6 commits intorelease/0.7from
true, include is *#1516tarazou9 merged 6 commits intorelease/0.7from
Conversation
tarazou9
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard and
severussundar
as code owners
Collaborator
|
Shouldn't the PR merge target be Also, please provide better description in the title and PR description of what this cherry pick bug fix is about. |
Contributor
Author
Updated. :) |
Aniruddh25
changed the title
true, include is *
Aniruddh25
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
graphqlis set to true without singular type specified in runtime config file, in addition to when field authincludepermission is using WILDCARD, this was giving user's access forbidden error.What is this change?
GraphQLSingularTypeToEntityNameMapinRuntimeConfig.csis not adding the entity type when there is no singular type passed in, and for WILDCARD permission check, theAuthorizationResolveris retrieving all the fields columns using theGraphQLSingularTypeToEntityNameMapkeys.How was this tested?