Fix issue when graphql is true and include permission is WILDCARD#1501
Merged
Fix issue when graphql is true and include permission is WILDCARD#1501
Conversation
tarazou9
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard and
severussundar
as code owners
mbhaskar
reviewed
May 16, 2023
aaronpowell
reviewed
May 17, 2023
Contributor
|
I feel like #1402 will tackle this as it is more aggressive in the way that it sets the singular name, resulting in the |
Aniruddh25
reviewed
May 17, 2023
Aniruddh25
reviewed
May 17, 2023
Aniruddh25
approved these changes
May 19, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix and testing all other scenarios!
abhishekkumams
approved these changes
May 23, 2023
Contributor
abhishekkumams
left a comment
abhishekkumams
left a comment
There was a problem hiding this comment.
LGTM, Thanks @tarazou9 for addressing the change quickly.
seantleonard
approved these changes
May 23, 2023
….com/Azure/data-api-builder into usrs/tarazou/fieldAuthNoSingularType
1 task
tarazou9
added a commit
that referenced
this pull request
May 24, 2023
## Why make this change? - This is for cherry-pick the bug fix from main into the release 0.7 ## What is this change? Here is the PR merged in main for the fix. #1501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
graphqlis set to true without singular type specified in runtime config file, in addition to when field authincludepermission is using WILDCARD, this was giving user's access forbidden error.What is this change?
GraphQLSingularTypeToEntityNameMapinRuntimeConfig.csis not adding the entity type when there is no singular type passed in, and for WILDCARD permission check, theAuthorizationResolveris retrieving all the fields columns using theGraphQLSingularTypeToEntityNameMapkeys.How was this tested?