Merged
Conversation
mbhaskar
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Mathos1432
approved these changes
May 12, 2023
kavyako
reviewed
May 12, 2023
Aniruddh25
reviewed
May 12, 2023
Aniruddh25
approved these changes
May 12, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, curious to know how this will be useful
Moving GetProductVersion() from CLI to DABUtils Adding test for testing user agent set from env var
aaronburtle
reviewed
May 12, 2023
Aniruddh25
reviewed
May 12, 2023
aaronburtle
approved these changes
May 12, 2023
Contributor
aaronburtle
left a comment
aaronburtle
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for splitting the Utils out to be more generally usable.
Collaborator
nit: this const string In reply to: 1546376014 Refers to: src/Cli/Utils.cs:29 in 98bd1f9. [](commit_id = 98bd1f9, deletion_comment = False) |
Member
Author
|
removed |
This was referenced Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Fixes #1485
Adds user agent to cosmos client.
What is this change?
Adding user agent to cosmos client.
How was this tested?