Support time data type in MsSql and fix for datetime types#1473
Merged
abhishekkumams merged 65 commits intomainfrom Aug 17, 2023
Merged
Support time data type in MsSql and fix for datetime types#1473abhishekkumams merged 65 commits intomainfrom
time data type in MsSql and fix for datetime types#1473abhishekkumams merged 65 commits intomainfrom
Conversation
Aniruddh25
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
ayush3797
reviewed
May 8, 2023
seantleonard
reviewed
Aug 1, 2023
seantleonard
reviewed
Aug 1, 2023
Aniruddh25
commented
Aug 2, 2023
Collaborator
Author
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Few more questions
…upportedTypesTestsBase.cs Co-authored-by: Sean Leonard <[email protected]>
…upportedTypesTestsBase.cs Co-authored-by: Sean Leonard <[email protected]>
abhishekkumams
approved these changes
Aug 4, 2023
Aniruddh25
commented
Aug 8, 2023
Aniruddh25
commented
Aug 9, 2023
Collaborator
Author
|
Approved but since I authored it initially, can't represent it in github. Can consider @abhishekkumams approval on my behalf. |
Co-authored-by: Aniruddh Munde <[email protected]>
ayush3797
reviewed
Aug 16, 2023
seantleonard
approved these changes
Aug 16, 2023
1 task
Aniruddh25
changed the title
time data type in MsSqltime data type in MsSql and fix for datetime types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
timedata type in MsSql #1401What is this change?
timedata type is detected asTimeSpanin C#. Add respective additional case for this type where ever types are handled.Additional Fixes
How was this tested? Work in progress
SupportedTypeStoredProcedureBuilderTestsSample Request(s)
No Implicit Time Zone Conversion: you see exactly what you have on DB, same for insert/update