Add support for Cosmos field level auth#1468
Merged
Conversation
tarazou9
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard and
severussundar
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
Aniruddh25
reviewed
May 3, 2023
Aniruddh25
reviewed
May 3, 2023
Aniruddh25
reviewed
May 3, 2023
Aniruddh25
reviewed
May 3, 2023
Aniruddh25
reviewed
May 3, 2023
seantleonard
reviewed
May 9, 2023
Aniruddh25
reviewed
May 10, 2023
Aniruddh25
requested changes
May 10, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Thank for implementing this new feature! Few more concerns then its good to go
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
nits on naming/comments to clarify intent.
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
last nit, otherwise looks good!
Aniruddh25
reviewed
May 10, 2023
Aniruddh25
reviewed
May 10, 2023
Aniruddh25
reviewed
May 10, 2023
Aniruddh25
approved these changes
May 10, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contributions :)
seantleonard
approved these changes
May 11, 2023
abhishekkumams
approved these changes
May 11, 2023
1 task
1 task
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
GraphQLFilterParserfor Cosmos.WILDCARDand parse all the columns from schema.gqlIncludedandExcludedcolumns from runtime config by injectingAuthorizationResolverinto theCosmosMutationEngineto make a call to check the columns.How was this tested?