Skip to content

[Bug]: Merged configuration file always has the optional properties with their default values if they are not specified in the overridden file #1737

@Aniruddh25

Description

@Aniruddh25

What happened?

Example:
dab-config.json => base config has graphql enabled = false.

{
“graphql”:  {
               “enabled”: false
               } 
}

dab-config.development.json => no graphql options provided explicitly

{
“graphql”: { }
}

We deserialize and initialize the “graphql” options with enabled = true for dab-config.development.json

Merging the base dab-config.json + the override- dab-config.development.json would lead to this:

{
“graphql”:  {
               “enabled”: true
               } 
}

Even though, correct merge should have retained the base config, i.e. enabled =false.

Version

0.8.51

What database are you using?

Azure SQL

What hosting model are you using?

Local (including CLI)

Which API approach are you accessing DAB through?

REST, GraphQL

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriageissues to be triaged

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions