Skip to content

Commit 6e8ac9f

Browse files
aaronburtleaaronburtle
authored
Hot Reload test fix (#3018)
## Why make this change? Closes #2010 Note that hot-reload of the graphQL schema is bugged currently, and tests are still ignored until this issue is resolved: #3019 ## What is this change? As documented in the issue above, a number of hot-reload tests were failing due to relying on a simple timeout to allow the hot-reload to complete within tests. This creates a number of potential problems, including potential race conditions within the tests. We replace that strategy with a waiting process and change from syn to async in a number of functions. We also cleanup the config creation in the tests so that the new properties added since these tests were ignored fit into the flow and expectations of the tests. ## How was this tested? The previously ignored tests are now run and have the ignore tag removed. ## Sample Request(s) N/A
1 parent 64f28dc commit 6e8ac9f

2 files changed

Lines changed: 283 additions & 104 deletions

File tree

‎.pipelines/mssql-pipelines.yml‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ jobs:
122122
displayName: 'Run MsSql Integration Tests'
123123
inputs:
124124
command: test
125-
arguments: '--filter "TestCategory=MsSql" --no-build --configuration $(buildConfiguration) --collect "XPlat Code coverage"'
125+
arguments: '--filter "TestCategory=MsSql&FullyQualifiedName!~ConfigurationHotReloadTests" --no-build --configuration $(buildConfiguration) --collect "XPlat Code coverage"'
126126
projects: '**/*Tests/*.csproj'
127127

128128
- task: CmdLine@2
@@ -246,11 +246,20 @@ jobs:
246246
targetFiles: 'src/out/tests/*/dab-config.MsSql.json'
247247

248248
- task: DotNetCoreCLI@2
249-
displayName: 'Run MsSql Integration Tests'
249+
displayName: 'MsSql Integration Tests'
250+
inputs:
251+
command: test
252+
arguments: '--filter "TestCategory=MsSql&FullyQualifiedName!~ConfigurationHotReloadTests" --no-build --configuration $(buildConfiguration) --collect "XPlat Code coverage"'
253+
projects: '**/*Tests/*.csproj'
254+
255+
256+
- task: DotNetCoreCLI@2
257+
displayName: 'Hot-Reload Tests'
250258
inputs:
251259
command: test
252-
arguments: '--filter "TestCategory=MsSql" --no-build --configuration $(buildConfiguration) --collect "XPlat Code coverage"'
260+
arguments: '--filter "TestCategory=MsSql&FullyQualifiedName~ConfigurationHotReloadTests" --no-build --configuration $(buildConfiguration) --collect "XPlat Code coverage" --logger "console;verbosity=detailed"'
253261
projects: '**/*Tests/*.csproj'
262+
timeoutInMinutes: 45
254263

255264
- task: PublishCodeCoverageResults@1
256265
displayName: 'Publish code coverage'

0 commit comments

Comments
 (0)