Skip to content

Commit 4ef54ec

Browse files
Copilotvadeveka
andcommitted
Cherry-pick #2887: Fix stored procedure empty cell bug
Co-authored-by: vadeveka <[email protected]>
1 parent 7c697a0 commit 4ef54ec

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

src/Service.Tests/SqlTests/GraphQLPaginationTests/GraphQLPaginationTestBase.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ public async Task RequestMaxUsingNegativeOne()
175175
""hasNextPage"": false
176176
}";
177177

178-
// Note: The max page size is 21 for MsSql and 20 for all other data sources, so when using -1
179178
// this resultset represents all books in the db.
180179
JsonElement actual = await ExecuteGraphQLRequestAsync(graphQLQuery, graphQLQueryName, isAuthenticated: false);
181180

src/Service.Tests/UnitTests/SqlQueryExecutorUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ public void ValidateStreamingLogicForStoredProcedures(int readDataLoops, bool ex
628628
/// Makes sure the stream logic handles cells with empty strings correctly.
629629
/// </summary>
630630
[DataTestMethod, TestCategory(TestCategory.MSSQL)]
631-
public void ValidateStreamingLogicForEmptyCellsAsync()
631+
public void ValidateStreamingLogicForEmptyCells()
632632
{
633633
TestHelper.SetupDatabaseEnvironment(TestCategory.MSSQL);
634634
FileSystem fileSystem = new();

0 commit comments

Comments
 (0)