Skip to content

Commit 098fbcc

Browse files
Copilotanushakolan
andcommitted
Remove redundant cloud-specific DataRows from tests
Removed duplicate DataRows for gov/china/managed instance clouds since they just test string assignment and don't actually validate cloud endpoints. Kept essential test cases: enabled only, audience only, and both together. Test count reduced from 12 to 9 tests while maintaining full coverage. Co-authored-by: anushakolan <[email protected]>
1 parent 572e924 commit 098fbcc

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

src/Cli.Tests/ConfigureOptionsTests.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1107,10 +1107,7 @@ private void SetupFileSystemWithInitialConfig(string jsonConfig)
11071107
[DataTestMethod]
11081108
[DataRow(true, null, DisplayName = "Set enabled=true only")]
11091109
[DataRow(null, "https://database.windows.net", DisplayName = "Set database-audience only")]
1110-
[DataRow(true, "https://database.windows.net", DisplayName = "Set both enabled and database-audience (public cloud)")]
1111-
[DataRow(true, "https://database.usgovcloudapi.net", DisplayName = "Set both enabled and database-audience (gov cloud)")]
1112-
[DataRow(true, "https://database.chinacloudapi.cn", DisplayName = "Set both enabled and database-audience (china cloud)")]
1113-
[DataRow(true, "https://myinstance.abc123.database.windows.net", DisplayName = "Set both enabled and database-audience (managed instance)")]
1110+
[DataRow(true, "https://database.windows.net", DisplayName = "Set both enabled and database-audience")]
11141111
public void TestAddUserDelegatedAuthConfiguration(bool? enabledValue, string? audienceValue)
11151112
{
11161113
// Arrange

0 commit comments

Comments
 (0)