Merged
Conversation
annatisch
approved these changes
Jan 25, 2021
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
LGTM - maybe add changelog notes?
Contributor
Author
|
@annatisch , I'm a bit torn on mentioning it the release note as it's not part of the core amqp spec and it's there to support eventhub scenario. apart from that, do you think the naming of the parameter should be more explicit such as |
yunhaoling
commented
Jan 27, 2021
Contributor
Author
|
conclusion: not exposing the config now, also renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for the Event Hub Issue Azure/azure-sdk-for-python#16047.
eventhub PR: https://github.com/Azure/azure-sdk-for-python/pull/16295/files
I intend to hide "hostname" from the "auth" API surface first, as it's not part of the AMQP spec for a feature for EH only