Skip to content

Create PR to target against master#1266

Merged
1 commit merged intoAzure:masterfrom
sima-zhu:pr_to_master
Dec 10, 2020
Merged

Create PR to target against master#1266
1 commit merged intoAzure:masterfrom
sima-zhu:pr_to_master

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Dec 9, 2020 •
edited
Loading

We did not observe OPS build issue recently. The migration actually solves the build time and build error problems at the same time. We can move forward with smoke-test deprecation work.

@sima-zhu sima-zhu requested a review from a team as a code owner December 9, 2020 02:19
@sima-zhu sima-zhu requested a review from scbedd December 9, 2020 02:19
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 9, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

scbedd
scbedd approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say "we haven't seen the OPS issue lately"

We only saw that issue when the build job wrote directly to master IIRC. Have we tried that?

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Dec 9, 2020

When you say "we haven't seen the OPS issue lately"

We only saw that issue when the build job wrote directly to master IIRC. Have we tried that?

I remember the issue is for builds after checking in commits. I am checking the failed builds we have recently (around 1 month). We can see the build reports real error instead of SSO errors only. However, this is just by observations, and not proved by any concrete evidence.

This was referenced Dec 10, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Dec 10, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Dec 10, 2020

/check-enforcer override

@ghost ghost merged commit 375351b into Azure:master Dec 10, 2020
@sima-zhu sima-zhu deleted the pr_to_master branch December 10, 2020 21:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scbedd scbedd scbedd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sima-zhu @azure-sdk @scbedd