Conversation
yunhaoling
commented
Nov 7, 2019
- Step1: ripping off EventHubClient, EventHubClientAbstract
- Step2: using uAMQP push model directly
|
Can one of the admins verify this patch? |
…-sdk-for-python into eventhubs_refactor_test
|
At least some of the samples do not currently run: At least in this case the proximate issue seems to be a parameter name change I would suggest making sure all the samples run before merging this. Beyond that, I think this is at the stage where it's probably easier to merge the large PR and follow on with more smaller digestible chunks after. |
KieranBrantnerMagee
left a comment
There was a problem hiding this comment.
Broadly LGTM (for as much detail much as the limited time allowed). The remaining open comments from me are largely nits, so I trust owners to handle reasonably.
Would still sanity check that other reviewers were OK with their resolutions, as I can't speak for them.
|
Hey @bryevdv, the callback now gives you a single event instead of giving you a list of events. There are still API changes that needs to be updated after this refactor PR, so we'd prefer update samples after all the changes has been done. |
It's not what I would do (I think change sets should be as "atomic" as possible and working at every PR merge), but in that case I'd suggest making a separate issue at least. |
|
@bryevdv - Agreed and updated. :) |
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |