Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates error handling details for the agents API by introducing a new AgentErrorDetail model and replacing the previous AgentV1ErrorError model. Key changes include:
- Replacing AgentV1ErrorError with the new AgentErrorDetail class in error payloads.
- Updating references in related modules (init.py, apiview-properties.json) and the version/changelog.
- Bumping the package version to reflect the update.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-agents/tsp-location.yaml | Updated commit hash for consistency. |
| sdk/ai/azure-ai-agents/azure/ai/agents/models/_models.py | Introduced AgentErrorDetail and updated error field type in AgentV1Error. |
| sdk/ai/azure-ai-agents/azure/ai/agents/models/init.py | Adjusted import and all to include AgentErrorDetail and remove AgentV1ErrorError. |
| sdk/ai/azure-ai-agents/azure/ai/agents/_version.py | Bumped version to 1.0.0b3. |
| sdk/ai/azure-ai-agents/apiview-properties.json | Updated API view properties to reflect changes in error model. |
| sdk/ai/azure-ai-agents/CHANGELOG.md | Added changelog entry for the new release. |
Comments suppressed due to low confidence (1)
sdk/ai/azure-ai-agents/azure/ai/agents/models/_models.py:205
- [nitpick] Consider whether using 'type' as a field name might lead to confusion with the built-in 'type' function. If this naming aligns with our model specifications, it is acceptable; otherwise, consider an alternative like 'error_type'.
type: Optional[str] = rest_field(visibility=["read", "create", "update", "delete", "query"])
glharper
approved these changes
May 14, 2025
M-Hietala
approved these changes
May 14, 2025
nick863
approved these changes
May 14, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
glharper
approved these changes
May 14, 2025
dargilco
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update agent error detail