Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the usage of AIAgentsInstrumentor in the Azure Monitor tracing samples to simplify telemetry initialization and reduce overhead.
- Removed try-except blocks that called AIAgentsInstrumentor.instrument() from all relevant sample files.
- Updated multiple sample files by omitting the instrumentation call in favor of directly configuring Azure Monitor.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_toolset_with_azure_monitor_tracing.py | Removed redundant instrumentation call |
| sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_stream_eventhandler_with_azure_monitor_tracing.py | Removed redundant instrumentation call |
| sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py | Removed redundant instrumentation call |
| sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_async_with_azure_monitor_tracing.py | Removed redundant instrumentation call |
| sdk/ai/azure-ai-agents/samples/agents_multiagent/utils/agent_trace_configurator.py | Removed redundant instrumentation call |
jhakulin
approved these changes
May 13, 2025
…mples_for_azure_monitor_tracing
…mples_for_azure_monitor_tracing
…mples_for_azure_monitor_tracing
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
jhakulin
approved these changes
May 14, 2025
M-Hietala
deleted the
m-hietala/removing_instrumentor_call_from_samples_for_azure_monitor_tracing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines