Merged
Conversation
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
xiangyan99
requested review from
KarishmaGhiya,
billwert,
chlowell,
maorleger,
mpodwysocki and
schaabs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for selecting credential groups via the new AZURE_TOKEN_CREDENTIALS environment variable. It adds tests to cover async and sync credential selection behaviors, updates the default version, and updates configuration constants and changelog accordingly.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/identity/azure-identity/tests/test_token_credentials_env_async.py | Added tests for async credential selection based on AZURE_TOKEN_CREDENTIALS. |
| sdk/identity/azure-identity/tests/test_token_credentials_env.py | Added tests for sync credential selection based on AZURE_TOKEN_CREDENTIALS. |
| sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py | Updated async DefaultAzureCredential to support the new environment variable. |
| sdk/identity/azure-identity/azure/identity/_version.py | Bumped version from 1.22.1 to 1.23.0. |
| sdk/identity/azure-identity/azure/identity/_credentials/default.py | Updated sync DefaultAzureCredential to support the new environment variable. |
| sdk/identity/azure-identity/azure/identity/_constants.py | Introduced AZURE_TOKEN_CREDENTIALS constant. |
| sdk/identity/azure-identity/CHANGELOG.md | Documented changes for release 1.23.0. |
sdk/identity/azure-identity/tests/test_token_credentials_env.py
Outdated
Show resolved
Hide resolved
pvaneck
reviewed
May 13, 2025
sdk/identity/azure-identity/tests/test_token_credentials_env_async.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/tests/test_token_credentials_env.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/tests/test_token_credentials_env.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/tests/test_token_credentials_env_async.py
Outdated
Show resolved
Hide resolved
…sync.py Co-authored-by: Paul Van Eck <[email protected]>
Co-authored-by: Paul Van Eck <[email protected]>
Co-authored-by: Paul Van Eck <[email protected]>
…sync.py Co-authored-by: Paul Van Eck <[email protected]>
Co-authored-by: Paul Van Eck <[email protected]>
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
github-project-automation
bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a way to environmentally configure what set of credentials are used in DefaultAzureCredential.