Adding data collection disclosure to readme#40989
Merged
sandeep-sen merged 10 commits intoAzure:mainfrom May 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new section to the README to notify users about data collection and provide instructions on how to disable telemetry.
- Introduces a "Data Collection" section with telemetry details.
- Provides example code showing how to disable telemetry for the SDK.
Comments suppressed due to low confidence (1)
README.md:78
- The code uses 'default_credential' which is not defined; consider replacing it with 'credential' to match the earlier credential initialization.
blob_service_client = BlobServiceClient(account_url, credential=default_credential, user_agent_policy=None)
sandeep-sen
requested review from
catalinaperalta,
iscai-msft,
kashifkhan,
kristapratico,
l0lawrence,
lmazuel,
mccoyp,
pvaneck,
swathipil and
xiangyan99
l0lawrence
reviewed
May 9, 2025
pvaneck
reviewed
May 9, 2025
Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Krista Pratico <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a data collection disclosure section to the README, detailing telemetry practices and how users can opt out.
- A "Data Collection" section has been added to inform users about telemetry.
- Telemetry configuration instructions, including a code example with a custom NoUserAgentPolicy, have been introduced.
pvaneck
reviewed
May 13, 2025
Member
pvaneck
left a comment
pvaneck
left a comment
There was a problem hiding this comment.
One inline code suggestion, but otherwise LGTM.
Co-authored-by: Paul Van Eck <[email protected]>
pvaneck
approved these changes
May 13, 2025
mccoyp
reviewed
May 13, 2025
kristapratico
approved these changes
May 13, 2025
Co-authored-by: McCoy Patiño <[email protected]>
kristapratico
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with the Open source release checklist adding a telemetry notice and how to opt out.
See setp 4 in https://docs.opensource.microsoft.com/releasing/#release-checklist