Sync eng/common directory with azure-sdk-tools for PR 10522#40860
Merged
Sync eng/common directory with azure-sdk-tools for PR 10522#40860
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with upstream changes from azure-sdk-tools, specifically for PR 10522.
- Removed the NodeTool@0 step that sets up Node.js 18.x in the check-spelling pipeline
- Retained the PowerShell-based cspell check configuration
Comments suppressed due to low confidence (1)
eng/common/pipelines/templates/steps/check-spelling.yml:16
- Removing the NodeTool@0 step means Node.js 18.x is no longer explicitly configured. Ensure that the PowerShell-based spell check still meets the environment requirements for cspell, or add an alternative step to establish the necessary Node.js version if required.
- - task: NodeTool@0
danieljurek
approved these changes
May 2, 2025
azure-sdk
force-pushed
the
sync-eng/common-djurek/cspell-node-10522
branch
from
c6111fa to
dd40cc8
Compare
danieljurek
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10522 See eng/common workflow