[Identity] Deprecate VisualStudioCodeCredential#40613
Merged
pvaneck merged 1 commit intoAzure:mainfrom Apr 21, 2025
Merged
Conversation
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
This credential is deprecated because the Azure Account extension for Visual Studio Code, which this credential relies on, has been deprecated. Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
identity-vscode-deprecation
branch
from
3328940 to
4f258b8
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
pvaneck
requested review from
KarishmaGhiya,
billwert,
joshfree,
maorleger,
mpodwysocki and
scottaddie
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request deprecates the VisualStudioCodeCredential by updating its warning messages, removing its troubleshooting documentation, and updating related tests and README instructions to reflect the deprecation.
- Updated deprecation messages in both synchronous and asynchronous implementations of VisualStudioCodeCredential.
- Adjusted tests to verify deprecation warnings and modified documentation in README, TROUBLESHOOTING.md, and the CHANGELOG.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/identity/azure-identity/tests/test_vscode_credential_async.py | Added deprecation warning test for asynchronous credential. |
| sdk/identity/azure-identity/tests/test_vscode_credential.py | Added deprecation warning test and removed skip marker on get_credential. |
| sdk/identity/azure-identity/azure/identity/aio/_credentials/vscode.py | Updated deprecation notices in the asynchronous credential implementation. |
| sdk/identity/azure-identity/azure/identity/_credentials/vscode.py | Updated deprecation warning and documentation in the synchronous credential implementation. |
| sdk/identity/azure-identity/TROUBLESHOOTING.md | Removed troubleshooting section for VisualStudioCodeCredential. |
| sdk/identity/azure-identity/README.md | Removed VisualStudioCodeCredential instructions and updated credential guidance. |
| sdk/identity/azure-identity/CHANGELOG.md | Documented deprecation of VisualStudioCodeCredential. |
Comments suppressed due to low confidence (2)
sdk/identity/azure-identity/tests/test_vscode_credential.py:365
- [nitpick] Consider enhancing the deprecation warning test to assert the expected deprecation warning message content to ensure consistency in future changes.
def test_deprecation_warning():
sdk/identity/azure-identity/tests/test_vscode_credential_async.py:356
- [nitpick] Consider enhancing the deprecation warning test to assert the expected deprecation warning message content to ensure consistency in future changes.
def test_deprecation_warning():
scottaddie
approved these changes
Apr 21, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
github-project-automation
bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
This credential is deprecated because the Azure Account extension for Visual Studio Code, which this credential relies on, has been deprecated. Signed-off-by: Paul Van Eck <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This credential is deprecated because the Azure Account extension for Visual Studio Code, which this credential relies on, has been deprecated.
Closes: #39964
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines