Allow for alphanumeric in column mapping#40556
Merged
slister1001 merged 3 commits intoAzure:mainfrom Apr 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the regex used in column mapping to allow alphanumeric characters, addressing the issue where data fields with numeric characters were erroneously rejected.
- Updated regex in _evaluate.py to include digits
- Updated CHANGELOG.md to document the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| _evaluate/_evaluate.py | Modified regex to accept numeric characters in column mappings. |
| CHANGELOG.md | Added changelog entry explaining the numeric character support fix. |
github-actions
bot
added
the
Evaluation
Collaborator
|
API change check API changes are not detected in this pull request. |
nagkumar91
approved these changes
Apr 18, 2025
Contributor
|
Please add a unit test which can help prevent regression. Thanks a lot raising the PR |
nagkumar91
approved these changes
Apr 21, 2025
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
* Allow for alphanumeric in column mapping * add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines