[RedTeam] Call evaluate_with_rai_service instead of evaluate#40520
Merged
slister1001 merged 9 commits intoAzure:mainfrom Apr 20, 2025
Merged
[RedTeam] Call evaluate_with_rai_service instead of evaluate#40520slister1001 merged 9 commits intoAzure:mainfrom
slister1001 merged 9 commits intoAzure:mainfrom
Conversation
github-actions
bot
added
the
Evaluation
Collaborator
|
API change check API changes are not detected in this pull request. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/red_team/_red_team.py:1371
- It appears that 'strategy' is used instead of 'strategy_name' (as seen in the logging call), which could lead to unexpected behavior if 'strategy' is undefined. Consider replacing 'strategy' with 'strategy_name' for consistency.
self.red_team_info[self._get_strategy_name(strategy)][risk_category.value]["evaluation_result_file"] = str(result_path)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/red_team/_red_team.py:756
- Changing the batch index from an incremented value (batch_idx+1) to a constant (1) may be unintentional. Verify that resetting batch_idx to 1 is the intended behavior for processing output files.
self._write_pyrit_outputs_to_file(orchestrator=orchestrator, strategy_name=strategy_name, risk_category=risk_category, batch_idx=1)
nagkumar91
approved these changes
Apr 18, 2025
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
* call evaluate_with_rai_service instead of evaluate * clean up * bug fixes * add retry logic to service calls and send_prompt_async * small fixes * update retry to handle asyncio timeout * fix attack success
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines