Skip to content

[AutoPR adhybridhealthservice/resource-manager] [Portal Generated] Review request for Microsoft.ADHybridHealthService to add version 2014-01-01#4040

Merged
AutorestCI merged 2 commits intorestapi_auto_adhybridhealthservice/resource-managerfrom
restapi_auto_4880
Dec 14, 2018
Merged

[AutoPR adhybridhealthservice/resource-manager] [Portal Generated] Review request for Microsoft.ADHybridHealthService to add version 2014-01-01#4040
AutorestCI merged 2 commits intorestapi_auto_adhybridhealthservice/resource-managerfrom
restapi_auto_4880

Conversation

@AutorestCI
Copy link
Contributor

@AutorestCI AutorestCI commented Dec 11, 2018

@AutorestCI
Generated from 5269a33bc4e48e336b7eacdba01c999953f42013
2ac02c8 
Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
@AutorestCI AutorestCI requested a review from lmazuel as a code owner December 11, 2018 05:22
@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
2 tasks
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Dec 11, 2018 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-adhybridhealthservice

You can install the package azure-mgmt-adhybridhealthservice of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_4880#egg=azure-mgmt-adhybridhealthservice&subdirectory=azure-mgmt-adhybridhealthservice"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_4880#egg=azure-mgmt-adhybridhealthservice&subdirectory=azure-mgmt-adhybridhealthservice"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_4880
  • pip install -e ./azure-mgmt-adhybridhealthservice

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_4880
  • pip wheel --no-deps ./azure-mgmt-adhybridhealthservice

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #4040 into restapi_auto_adhybridhealthservice/resource-manager will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@                                   Coverage Diff                                   @@
##           restapi_auto_adhybridhealthservice/resource-manager    #4040      +/-   ##
=======================================================================================
+ Coverage                                                56.19%   56.77%   +0.58%     
=======================================================================================
  Files                                                     9424     8789     -635     
  Lines                                                   196016   176703   -19313     
=======================================================================================
- Hits                                                    110142   100330    -9812     
+ Misses                                                   85874    76373    -9501
Impacted Files Coverage Δ
...azure/mgmt/eventgrid/models/topic_type_info_py3.py 41.66% <0%> (-58.34%) ⬇️
...rid/azure/mgmt/eventgrid/models/topic_type_info.py 41.66% <0%> (-58.34%) ⬇️
...ntgrid/azure/mgmt/eventgrid/models/resource_py3.py 55.55% <0%> (-44.45%) ⬇️
...zure/mgmt/eventgrid/models/tracked_resource_py3.py 62.5% <0%> (-37.5%) ⬇️
...azure/graphrbac/models/required_resource_access.py 55.55% <0%> (-36.76%) ⬇️
...raphrbac/azure/graphrbac/models/resource_access.py 55.55% <0%> (-36.76%) ⬇️
...re-graphrbac/azure/graphrbac/models/graph_error.py 63.63% <0%> (-36.37%) ⬇️
...mt/eventgrid/models/dead_letter_destination_py3.py 75% <0%> (-25%) ⬇️
...tgrid/models/event_subscription_destination_py3.py 75% <0%> (-25%) ⬇️
...c/azure/graphrbac/operations/objects_operations.py 25.45% <0%> (-23.83%) ⬇️
... and 976 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af802b...099e83d. Read the comment docs.

@AutorestCI
Generated from 5269a33bc4e48e336b7eacdba01c999953f42013
099e83d 
Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
@AutorestCI AutorestCI merged commit ceb198e into restapi_auto_adhybridhealthservice/resource-manager Dec 14, 2018
@AutorestCI AutorestCI deleted the restapi_auto_4880 branch December 14, 2018 17:59
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Dec 14, 2018

This PR has been merged into #3883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

RestPRMerged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AutorestCI @codecov-io