[AutoRelease] t2-elasticsan-2025-04-03-61852(can only be merged by SDK owner)#40356
Merged
ChenxiJiang333 merged 4 commits intoAzure:mainfrom Apr 21, 2025
Merged
Conversation
Collaborator
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ElasticSan management SDK to add new operations (including begin_restore_volume) and models, update default API versions, enhance documentation and type annotations, and bump the version to 1.2.0b2. The changes also include improvements to docstrings and serialization/deserialization routines, and minor adjustments to import order and linter disables.
Reviewed Changes
Copilot reviewed 108 out of 109 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_skus_operations.py | Updates import and type hints for error_map variable. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_private_link_resources_operations.py | Similar update for error_map type hint and import style adjustments. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_private_endpoint_connections_operations.py | Adjusts error_map type hint with similar changes as other operation modules. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_operations.py | Revised error_map type hint and minor import cleanup. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_elastic_sans_operations.py | Updates error_map type hint in multiple operation methods. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_elastic_san_mgmt_client_operations.py | Adds new restore volume method along with standardizing error_map type hints. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/init.py | Reorders imports and ensures proper type-checking imports. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/_vendor.py | No behavioral changes; just codegen/structural adjustments. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/_elastic_san_mgmt_client.py | Updates the client class to inherit from the new operations mixin and bumps API version. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/_configuration.py | Updates the default API version to "2024-07-01-preview". |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/init.py | Import order and type-checking adjustments. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/_version.py | Bumps package version from 1.2.0b1 to 1.2.0b2. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/_vendor.py | Adds vendor file generated by AutoRest. |
| sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/_serialization.py | Enhances docstrings, updates type annotations, and standardizes formatting in serialization/deserialization routines. |
| sdk/elasticsan/azure-mgmt-elasticsan/_elastic_san_mgmt_client.py | Adjusts client initialization with new mixin and API version bump. |
| sdk/elasticsan/azure-mgmt-elasticsan/_configuration.py | Updates default API version value to "2024-07-01-preview". |
| sdk/elasticsan/azure-mgmt-elasticsan/init.py | Reorders imports and updates all for patching support. |
| sdk/elasticsan/azure-mgmt-elasticsan/README.md | Clarifies documentation regarding environment configuration. |
| sdk/elasticsan/azure-mgmt-elasticsan/CHANGELOG.md | Adds release notes for version 1.2.0b2 outlining new features and changes. |
Files not reviewed (1)
- sdk/elasticsan/azure-mgmt-elasticsan/_meta.json: Language not supported
Comments suppressed due to low confidence (2)
sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_skus_operations.py:76
- Consider specifying explicit generic type parameters for 'error_map' (e.g. MutableMapping[int, Type[HttpResponseError]]) to maintain clarity and improve type safety.
error_map: MutableMapping = {
sdk/elasticsan/azure-mgmt-elasticsan/azure/mgmt/elasticsan/aio/operations/_private_link_resources_operations.py:70
- Consider specifying explicit generic type parameters for 'error_map' here as well to preserve the original type information for better readability and type checking.
error_map: MutableMapping = {
ChenxiJiang333
approved these changes
Apr 21, 2025
msyyc
approved these changes
Apr 21, 2025
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
…K owner) (#40356) * code and test * update testcases * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <[email protected]> Co-authored-by: ChenxiJiang333 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6005
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5643