[AutoRelease] t2-networkcloud-2025-04-02-99243(can only be merged by SDK owner)#40334
Merged
ChenxiJiang333 merged 2 commits intoAzure:mainfrom Apr 21, 2025
Merged
Conversation
Collaborator
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default API version from "2024-07-01" to "2024-10-01-preview" across all operations and configuration files while introducing a series of new models and enums to support enhanced logging, secret archival, and vulnerability scanning functionality. It also bumps the package version and includes minor documentation improvements.
Reviewed Changes
Copilot reviewed 208 out of 209 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| _kubernetes_cluster_features_operations.py | Updated API version default for Kubernetes cluster feature operations. |
| _consoles_operations.py, _clusters_operations.py, _cluster_managers_operations.py, _cloud_services_networks_operations.py, _bmc_key_sets_operations.py, _bare_metal_machines_operations.py, _bare_metal_machine_key_sets_operations.py, _agent_pools_operations.py | Consistently updated the default API version across various operations modules. |
| _network_cloud_mgmt_client_enums.py | Added new enum members for OS disk and storage appliance status. |
| _models_py3.py | Introduced new models (AnalyticsOutputSettings, SecretArchiveSettings, VulnerabilityScanningSettings, etc.) and updated existing model documentation. |
| init.py (models) | Updated initialization to export the new models and enums. |
| aio/_network_cloud_mgmt_client.py, aio/_configuration.py | Updated API version defaults in asynchronous client configurations. |
| _version.py, _network_cloud_mgmt_client.py, _configuration.py | Bumped version and updated API version defaults in synchronous files. |
| README.md | Fixed a documentation typo regarding environment variable configuration. |
| CHANGELOG.md | Added changelog entries for the new beta release detailing new features and model updates. |
Files not reviewed (1)
- sdk/networkcloud/azure-mgmt-networkcloud/_meta.json: Language not supported
Comments suppressed due to low confidence (6)
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/operations/_kubernetes_cluster_features_operations.py:52
- Verify that the new API version '2024-10-01-preview' is fully supported by all endpoints and update corresponding tests to validate behavior.
api_version: str = kwargs.pop("api_version", _params.pop("api-version", "2024-10-01-preview"))
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/models/_models_py3.py:2413
- [nitpick] Confirm that the new 'analytics_output_settings' property documentation and its use (in conjunction with the deprecated 'analytics_workspace_id') aligns with the design guidelines.
:ivar analytics_output_settings: The settings for the log analytics workspace used for output of logs from this cluster.
sdk/networkcloud/azure-mgmt-networkcloud/CHANGELOG.md:3
- [nitpick] Ensure the release date and version number match the intended beta release details before merging.
## 2.1.0b1 (2025-04-21)
sdk/networkcloud/azure-mgmt-networkcloud/README.md:27
- [nitpick] The wording has been clarified; please ensure similar corrections are applied consistently throughout the documentation.
By default, [Azure Active Directory](https://aka.ms/awps/aad) token authentication depends on correct configuration of the following environment variables.
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/aio/_configuration.py:36
- [nitpick] Ensure that asynchronous unit tests cover scenarios where the API version is overridden and that the new default is applied correctly.
api_version: str = kwargs.pop("api_version", "2024-10-01-preview")
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/_configuration.py:36
- [nitpick] Update tests to validate that the configuration correctly sets the new default API version '2024-10-01-preview' in production scenarios.
api_version: str = kwargs.pop("api_version", "2024-10-01-preview")
ChenxiJiang333
approved these changes
Apr 21, 2025
msyyc
approved these changes
Apr 21, 2025
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
…SDK owner) (#40334) * code and test * update testcases --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/5985
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=6093