Skip to content

Provider Revert Init Change#37252

Merged
mrm9084 merged 1 commit intoAzure:mainfrom
mrm9084:RevertInitChange
Sep 9, 2024
Merged

Provider Revert Init Change#37252
mrm9084 merged 1 commit intoAzure:mainfrom
mrm9084:RevertInitChange

Conversation

@mrm9084
Copy link
Member

@mrm9084 mrm9084 commented Sep 9, 2024

Description

Reverts the API change to the init method. The API should match the one here.

https://github.com/Azure/azure-sdk-for-python/blob/azure-appconfiguration-provider_1.2.0/sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py#L490

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-appconfiguration-provider

@mrm9084 mrm9084 merged commit f687033 into Azure:main Sep 9, 2024
@mrm9084 mrm9084 deleted the RevertInitChange branch September 9, 2024 17:26
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants