Skip to content

[breaking change detector] optimize changelog output#36600

Merged
msyyc merged 4 commits intomainfrom
break-detector-changelog-optmize-output
Jul 25, 2024
Merged

[breaking change detector] optimize changelog output#36600
msyyc merged 4 commits intomainfrom
break-detector-changelog-optmize-output

Conversation

@msyyc
Copy link
Member

@msyyc msyyc commented Jul 24, 2024

I am working on apply the breaking change detection tool in SDK generation pipeline and this PR contains:

Effect:
image

@msyyc msyyc requested a review from catalinaperalta July 24, 2024 03:10
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might get feedback on whether adding the separators (===== changelog start/end =====) is too noisy for people using the tool in their development process, if we do get that feedback we could consider optionally adding the changelog separators with some flag or configuration. This is fine for now though

@msyyc msyyc enabled auto-merge (squash) July 25, 2024 06:07
@msyyc
Copy link
Member Author

msyyc commented Jul 25, 2024

/check-enforcer override

@msyyc msyyc merged commit 883cc20 into main Jul 25, 2024
@msyyc msyyc deleted the break-detector-changelog-optmize-output branch July 25, 2024 08:30
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
* optimize changelog output

* update

* Update scripts/breaking_changes_checker/detect_breaking_changes.py

Co-authored-by: catalinaperalta <[email protected]>

* Update scripts/breaking_changes_checker/detect_breaking_changes.py

Co-authored-by: catalinaperalta <[email protected]>

---------

Co-authored-by: catalinaperalta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants