[EventHub] Raise error when primary key is rotated#36245
Merged
swathipil merged 11 commits intoAzure:mainfrom Aug 5, 2024
Merged
[EventHub] Raise error when primary key is rotated#36245swathipil merged 11 commits intoAzure:mainfrom
swathipil merged 11 commits intoAzure:mainfrom
Conversation
swathipil
changed the title
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
commented
Jul 30, 2024
swathipil
commented
Jul 30, 2024
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
requested review from
annatisch,
kashifkhan and
l0lawrence
as code owners
kashifkhan
reviewed
Aug 2, 2024
sdk/eventhub/azure-eventhub/azure/eventhub/_transport/_pyamqp_transport.py
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
l0lawrence
reviewed
Aug 5, 2024
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_transport/_uamqp_transport_async.py
Show resolved
Hide resolved
l0lawrence
reviewed
Aug 5, 2024
kashifkhan
reviewed
Aug 5, 2024
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
approved these changes
Aug 5, 2024
Member
Author
|
/azp run python - eventhub - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
added a commit
that referenced
this pull request
Sep 26, 2024
This reverts commit 3b2dfa4.
This was referenced Sep 26, 2024
swathipil
added a commit
that referenced
this pull request
Sep 30, 2024
w-javed
pushed a commit
to w-javed/azure-sdk-for-python
that referenced
this pull request
Oct 3, 2024
) * Revert "[EventHub] Raise error when primary key is rotated (Azure#36245)" This reverts commit 3b2dfa4. * skip windows tests
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* sync side fix for rotate primary key issue in hub * sync uamqp transport * add to async * remove print/cleanup * mypy/pylint * changelog * fix logging formatting * no retry on all auth exceptions * remove import error in uamqp recv, b/c no external dependency * mypy
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
) * Revert "[EventHub] Raise error when primary key is rotated (Azure#36245)" This reverts commit 3b2dfa4. * skip windows tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #33926
Currently, when the primary key is rotated while receiving from an Event Hub, it results in an auth-failed error from the service when updating/putting token. However, this auth-failed error is not raised to the user.
Changes:
More context: It gets caught internally in the exception, but on the next retry, it does not get raised on the re-opening of the ReceiveClient. This is b/c the [if client_ready check] allows the _open method to return even when client is not ready (i.e. False). When while is used, for example when auth-failed occurs during a management request, the client_ready waits for either True or an error to be raised. Because of client ready not waiting in the receive, the receive loops forever in the case of an
auth-failedexception.Investigated:
ifto awhilein the consumer._open client_ready check. However, this caused about 100% drop in receive perf.