Merged
Conversation
.\venv\Scripts\activate pip install -r dev_requirements.txt pip install tox<5 pip install -e . adjustments sample_critical_result_inference_async
fixes pylint
Radiology insights ga cb3
Radiology insights ga
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Update cspell file & fix some unknown words for typos
Member
|
/azp run python - codeowners-linter - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py
Outdated
Show resolved
Hide resolved
...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py
Outdated
Show resolved
Hide resolved
...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py
Show resolved
Hide resolved
...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py
Show resolved
Hide resolved
...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py
Show resolved
Hide resolved
...hinsights-radiologyinsights/azure/healthinsights/radiologyinsights/aio/_operations/_patch.py
Show resolved
Hide resolved
...hinsights-radiologyinsights/azure/healthinsights/radiologyinsights/aio/_operations/_patch.py
Show resolved
Hide resolved
...althinsights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference.py
Outdated
Show resolved
Hide resolved
...sights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference_async.py
Outdated
Show resolved
Hide resolved
...althinsights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference.py
Outdated
Show resolved
Hide resolved
...zure-healthinsights-radiologyinsights/samples/sample_complete_order_discrepancy_inference.py
Outdated
Show resolved
Hide resolved
- remove unused imports in patch.py - resolve duplicate references in models.py - resolve duplicate and wrong references in README.md
cbovijn
reviewed
Jul 24, 2024
...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py
Show resolved
Hide resolved
...althinsights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference.py
Outdated
Show resolved
Hide resolved
- move imports in samples - fix pylint and mypy issues in patch files
replace deserialize with job iso inference result
- fix bugs sample_laterality_discrepancy_inference.py - adjust _operations
replace deserialize Job with InferenceResult
...insights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_operations.py
Outdated
Show resolved
Hide resolved
- replace with expected code in _patch
fix mypy error in _patch.py (add ignore)
catalinaperalta
approved these changes
Jul 31, 2024
Member
catalinaperalta
left a comment
There was a problem hiding this comment.
Some samples were overlooked during the clean up process fyi
...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py
Outdated
Show resolved
Hide resolved
...sights/azure-healthinsights-radiologyinsights/samples/sample_sex_mismatch_inference_async.py
Outdated
Show resolved
Hide resolved
...althinsights/azure-healthinsights-radiologyinsights/samples/sample_sex_mismatch_inference.py
Outdated
Show resolved
Hide resolved
...azure-healthinsights-radiologyinsights/samples/sample_radiology_procedure_inference_async.py
Outdated
Show resolved
Hide resolved
...ights/azure-healthinsights-radiologyinsights/samples/sample_radiology_procedure_inference.py
Outdated
Show resolved
Hide resolved
adjust sample_radiology_procedure_inference to align with the other samples adjust sample_radiology_procedure_inference_async to align with the other samples adjust sample_sex_mismatch_inference to align with the other samples adjust sample_sex_mismatch_inference_async to align with the other samples
tomsft
approved these changes
Aug 2, 2024
xiangyan99
approved these changes
Aug 2, 2024
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* Update tsp-location.yaml with latest commit id * regenerated SDK .\venv\Scripts\activate pip install -r dev_requirements.txt pip install tox<5 pip install -e . adjustments sample_critical_result_inference_async * inference * Adjusted README.md * adjustment tests fixes pylint * fix get result call on inferences inside job * implementation RadiologyInsightsInferenceResult in samples and tests * removed headers from test files * cspell updates & fix typos Update cspell file & fix some unknown words for typos * fix tests in record mode * fix spelling errors * fix spelling error * Update sample_finding_inference.py * Update sample_finding_inference.py * fix reviewer comments * add breaking changes to changelog and fix pylint issue * Update assets.json * Regenerated SDK for authentication, adjusted samples * Update CHANGELOG.md * fixing PR conversations * small cosmetic changes * Update README.md * refactor sample and adjust changelog * Update sample_age_mismatch_inference_async.py * adjust async samples according to review * Update README.md * fix tests for other packages * Update assets.json * Update assets.json * Update assets.json * regenerated SDK * disable healthinsights tests * disable cancerprofiling and trialmatcher test * disable tests * remove key based authentication from samples and documentation * fix tests * push recordings to assets * change sync to async cred * remove credentials sample and update documentation * Update sdk/healthinsights/azure-healthinsights-radiologyinsights/README.md Co-authored-by: catalinaperalta <[email protected]> * Update sdk/healthinsights/azure-healthinsights-radiologyinsights/README.md Co-authored-by: catalinaperalta <[email protected]> * change samples and add a patch method * adjust tests * fix tests for radiology insights * - adjust def documentation in patch.py - remove unused imports in patch.py - resolve duplicate references in models.py - resolve duplicate and wrong references in README.md * - fix exception handling in samples - move imports in samples - fix pylint and mypy issues in patch files * remove class from sync samples replace deserialize with job iso inference result * - fix bugs sample_finding_inference.py - fix bugs sample_laterality_discrepancy_inference.py - adjust _operations * undo changes in patch files : replace deserialize Job with InferenceResult * - revert changes in _operations - replace with expected code in _patch * postprocess changes * revert _patch * fix pylint error in _operations.py fix mypy error in _patch.py (add ignore) * move ignore comment in _patch.py adjust sample_radiology_procedure_inference to align with the other samples adjust sample_radiology_procedure_inference_async to align with the other samples adjust sample_sex_mismatch_inference to align with the other samples adjust sample_sex_mismatch_inference_async to align with the other samples --------- Co-authored-by: cbovijn <[email protected]> Co-authored-by: Celia Bovijn <[email protected]> Co-authored-by: catalinaperalta <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines