Skip to content

qa more tests need rerecord#35249

Merged
kristapratico merged 1 commit intoAzure:mainfrom
kristapratico:qa-live
Apr 17, 2024
Merged

qa more tests need rerecord#35249
kristapratico merged 1 commit intoAzure:mainfrom
kristapratico:qa-live

Conversation

@kristapratico
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@xiangyan99
Copy link
Member

I don't see them fail in CI?

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@kristapratico
Copy link
Contributor Author

kristapratico commented Apr 17, 2024

@xiangyan99 they're failing on my PR: #35216

@kristapratico kristapratico merged commit 0832f65 into Azure:main Apr 17, 2024
@kristapratico kristapratico deleted the qa-live branch April 17, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants