[Core][Corehttp] Update multipart test-server code#35223
Merged
xiangyan99 merged 2 commits intoAzure:mainfrom Apr 16, 2024
Merged
[Core][Corehttp] Update multipart test-server code#35223xiangyan99 merged 2 commits intoAzure:mainfrom
xiangyan99 merged 2 commits intoAzure:mainfrom
Conversation
Aiohttp now doesn't set payload `Content-Length` headers. Let's stop checking content length in the test server assertions. Signed-off-by: Paul Van Eck <[email protected]>
Collaborator
|
API change check API changes are not detected in this pull request. |
pvaneck
requested review from
annatisch,
benbp,
iscai-msft,
johanste,
kashifkhan,
lmazuel,
scbedd,
weshaggard and
xiangyan99
as code owners
xiangyan99
approved these changes
Apr 16, 2024
xiangyan99
reviewed
Apr 16, 2024
Member
|
while it doesn't look to be the case, is the content length expected anywhere else in the case of multipart/form-data? |
kashifkhan
approved these changes
Apr 16, 2024
Member
|
These AI failures are not related to the change. |
Member
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiohttp now doesn't set payload
Content-Lengthheaders inmultipart/form-datarequests. The motivation was to conform to this RFC: https://datatracker.ietf.org/doc/html/rfc7578#section-4.8 where the Content-Length header is not allowed.Let's stop checking content length in the test server assertions to stop pipeline test failures. This also enables some multipart tests that were commented out.
Closes: #35220